-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StatefulSet API version to 1.9 for the Cassandra example #7096
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit b79bbb4 https://deploy-preview-7096--kubernetes-io-master-staging.netlify.com |
@@ -158,7 +158,7 @@ Use `kubectl edit` to modify the size of of a Cassandra StatefulSet. | |||
# and an empty file will abort the edit. If an error occurs while saving this file will be | |||
# reopened with the relevant failures. | |||
# | |||
apiVersion: apps/v1beta2 | |||
apiVersion: apps/v1 # for versions before 1.9.0 use apps/v1beta2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 171 should be changed.
if you change the API version, that v1beta1
should be v1
too.
of course original v1beta1
is wrong also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Thanks!
@zhangxiaoyu-zidif
/lgtm |
/approve |
There seems to be a bug in the ci-bot? @zhangxiaoyu-zidif Needs approval from an approver in each of these OWNERS Files: |
@cimomo if no owner file in this directory, https://github.com/kubernetes/website/blob/master/OWNERS would be the default one. so do not be worry. |
@zacharysarah @heckj for approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cimomo, heckj, zhangxiaoyu-zidif The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
…henopis-user-journeys * 'master' of https://github.com/kubernetes/website: (102 commits) Change deployment group (#7112) fix typos in extending doc (#7110) added installation via Powershell Gallery (#6086) Update StatefulSet API version to 1.9 for the Cassandra example (#7096) Modify the terms by document style (#7026) now that phase out in k8s/cluster/ directory, so remove relative docs (#6951) Update mysql-wordpress-persistent-volume.md (#7080) Update high-availability.md (#7086) Feature gates reference documentation (#6364) Add link to autoscaler FAQ (#7045) Replace regular characters with HTML entities. (#7038) Remove unnecessary manual node object creation (#6765) upper case restriction doesn't exist (#7003) Add an API concepts document and describe terminology and API chunking (#6540) Add kube-apiserver, kube-controller-manager, kube-scheduler and etcd to glossary. (#6600) Update what-is-kubernetes.md (#6971) Fixed the interacting with cluster section for the ubuntu installation (#6905) Update weave-network-policy.md (#6960) Added AWS eks (#6568) Update eviction strategy to include priority (#6949) ... # Conflicts: # _data/setup.yml # _data/tutorials.yml # docs/imported/release/notes.md
…rnetes#7096) * Update StatefulSet API version to 1.9 for the Cassandra example * Update API version for StatefulSet in the Cassandra example
Update StatefulSet API version to 1.9 for the Cassandra example.
This change is